status/network: Only show ornament in radio-mode

Soon only radio items should use a visible ornament, to avoid
unnecessary extra margins in regular items.

Network items can act as both radio- and regular items, so
update the ornament accordingly.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2843>

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index d73b37cea16d095b59f5496199a8a00ad1048074..000279e85c349f08f38ef4f7c0a1717e63f17ef1 100644 (file)
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -359,11 +359,6 @@ class NMConnectionItem extends NMMenuItem {
         this._sync();
     }
 
-    _updateOrnament() {
-        this.setOrnament(this.radio_mode && this.is_active
-            ? PopupMenu.Ornament.DOT : PopupMenu.Ornament.NONE);
-    }
-
     _getAccessibleName() {
         return this.is_active
             // Translators: %s is a device name like "MyPhone"
@@ -383,12 +378,14 @@ class NMConnectionItem extends NMMenuItem {
             this._subtitle.text = null;
             this.accessible_name = this.name;
             this.accessible_role = Atk.Role.CHECK_MENU_ITEM;
+            this.setOrnament(this.is_active
+                ? PopupMenu.Ornament.DOT : PopupMenu.Ornament.NONE);
         } else {
             this.accessible_name = this._getAccessibleName();
             this._subtitle.text = this._getSubtitleLabel();
             this.accessible_role = Atk.Role.MENU_ITEM;
+            this.setOrnament(PopupMenu.Ornament.HIDDEN);
         }
-        this._updateOrnament();
     }
 
     activate() {